linux-kernel - Re: [PATCH 2/2] usb: dwc3: drd: Avoid error when extcon is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201211141624.GQ4077@smile.fi.intel.com>
Date:   Fri, 11 Dec 2020 16:16:24 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Sam Protsenko <semen.protsenko@...aro.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH 2/2] usb: dwc3: drd: Avoid error when extcon is missing

On Thu, Dec 10, 2020 at 10:33:18PM +0200, Sam Protsenko wrote:
> If "port" node is missing in PHY controller node, dwc3_get_extcon()
> isn't able to find extcon device. This is perfectly fine in case when
> "usb-role-switch" or OTG is used, but next misleading error message is
> printed in that case, from of_graph_get_remote_node():
> 
>     OF: graph: no port node found in /phy@...4abcd
> 
> Avoid printing that message by checking if port node exists in PHY node
> before calling of_graph_get_remote_node().

By some reason you have two separate messages (missed --thread when run `git
format-patch ...`?).

In any case I think it should be dropped or reworked and resent since patch 1/2
got comments.

-- 
With Best Regards,
Andy Shevchenko