linux-kernel - Re: [PATCH -next] fs/xfs: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Dec 2020 08:55:12 -0800
From:   Joe Perches <joe@...ches.com>
To:     David Laight <David.Laight@...LAB.COM>,
        'Eric Sandeen' <sandeen@...deen.net>,
        Zheng Yongjun <zhengyongjun3@...wei.com>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "darrick.wong@...cle.com" <darrick.wong@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] fs/xfs: convert comma to semicolon

On Fri, 2020-12-11 at 16:17 +0000, David Laight wrote:
> From: Eric Sandeen
> > Sent: 11 December 2020 15:51
> > 
> > On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> > > Replace a comma between expression statements by a semicolon.
> > > 
> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> > 
> > hah, that's an old one.  Harmless though, AFAICT.
> > 
> > this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
> > if we dare add that tag ;)
> 
> It doesn't 'fix' anything, it is just stylistic.
> Completely harmless in every sense.

True, so it's not necessary to add a fixes tag here.

The only time a comma->semicolon conversion could 'fix'
something is when it's unintentionally used after something
like an if statement

	if (foo)
		bar(),
	baz();

where now baz() is performed only when the if condition is true
but the indentation indicates that it should always be performed.