linux-kernel - RE: [PATCH -next] fs/xfs: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f4ee9cf48a445cea25ba01bc9ffdf13@AcuMS.aculab.com>
Date:   Fri, 11 Dec 2020 16:17:47 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Eric Sandeen' <sandeen@...deen.net>,
        Zheng Yongjun <zhengyongjun3@...wei.com>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>,
        "darrick.wong@...cle.com" <darrick.wong@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] fs/xfs: convert comma to semicolon

From: Eric Sandeen
> Sent: 11 December 2020 15:51
> 
> On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> 
> hah, that's an old one.  Harmless though, AFAICT.
> 
> this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
> if we dare add that tag ;)

It doesn't 'fix' anything, it is just stylistic.
Completely harmless in every sense.

	David

> 
> Reviewed-by: Eric Sandeen <sandeen@...hat.com>
> 
> > ---
> >  fs/xfs/libxfs/xfs_btree.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> > index 2d25bab68764..51dbff9b0908 100644
> > --- a/fs/xfs/libxfs/xfs_btree.c
> > +++ b/fs/xfs/libxfs/xfs_btree.c
> > @@ -4070,7 +4070,7 @@ xfs_btree_delrec(
> >  	 * surviving block, and log it.
> >  	 */
> >  	xfs_btree_set_numrecs(left, lrecs + rrecs);
> > -	xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB),
> > +	xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB);
> >  	xfs_btree_set_sibling(cur, left, &cptr, XFS_BB_RIGHTSIB);
> >  	xfs_btree_log_block(cur, lbp, XFS_BB_NUMRECS | XFS_BB_RIGHTSIB);
> >
> >

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)