linux-kernel - Re: [PATCH -next] fs/xfs: convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd372b27-983d-00ff-5218-4082fe2f08df@sandeen.net>
Date:   Fri, 11 Dec 2020 09:51:15 -0600
From:   Eric Sandeen <sandeen@...deen.net>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>,
        linux-xfs@...r.kernel.org, darrick.wong@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] fs/xfs: convert comma to semicolon

On 12/11/20 2:41 AM, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>

hah, that's an old one.  Harmless though, AFAICT.

this fixes 91cca5df9bc8 ("[XFS] implement generic xfs_btree_delete/delrec")
if we dare add that tag ;)

Reviewed-by: Eric Sandeen <sandeen@...hat.com>

> ---
>  fs/xfs/libxfs/xfs_btree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c
> index 2d25bab68764..51dbff9b0908 100644
> --- a/fs/xfs/libxfs/xfs_btree.c
> +++ b/fs/xfs/libxfs/xfs_btree.c
> @@ -4070,7 +4070,7 @@ xfs_btree_delrec(
>  	 * surviving block, and log it.
>  	 */
>  	xfs_btree_set_numrecs(left, lrecs + rrecs);
> -	xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB),
> +	xfs_btree_get_sibling(cur, right, &cptr, XFS_BB_RIGHTSIB);
>  	xfs_btree_set_sibling(cur, left, &cptr, XFS_BB_RIGHTSIB);
>  	xfs_btree_log_block(cur, lbp, XFS_BB_NUMRECS | XFS_BB_RIGHTSIB);
>  
>