linux-kernel - Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201215194811.0505c1c5@canb.auug.org.au>
Date:   Tue, 15 Dec 2020 19:48:11 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rui.zhang@...el.com, lukasz.luba@....com,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with
 the energy model

Hi Daniel,

On Tue, 15 Dec 2020 09:35:20 +0100 Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
>
> The devfreq cooling device has been converted to use the energy model.
> 
> Add the dependency on the ENERGY_MODEL option to reflect this change
> and prevent build failure if the option is not set.
> 
> Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM")

Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>

> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> ---
>  drivers/thermal/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 7edc8dc6bbab..ee62d51ef351 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -193,6 +193,7 @@ config DEVFREQ_THERMAL
>  	bool "Generic device cooling support"
>  	depends on PM_DEVFREQ
>  	depends on PM_OPP
> +	depends on ENERGY_MODEL
>  	help
>  	  This implements the generic devfreq cooling mechanism through
>  	  frequency reduction for devices using devfreq.

Looks good to me.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped