linux-kernel - Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the energy model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Dec 2020 10:44:52 +0000
From:   Lukasz Luba <lukasz.luba@....com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rui.zhang@...el.com, linux-kernel@...r.kernel.org,
        linux-next@...r.kernel.org
Subject: Re: [PATCH] thermal/drivers/devfreq: Fix missing dependency with the
 energy model



On 12/15/20 8:48 AM, Stephen Rothwell wrote:
> Hi Daniel,
> 
> On Tue, 15 Dec 2020 09:35:20 +0100 Daniel Lezcano <daniel.lezcano@...aro.org> wrote:
>>
>> The devfreq cooling device has been converted to use the energy model.
>>
>> Add the dependency on the ENERGY_MODEL option to reflect this change
>> and prevent build failure if the option is not set.
>>
>> Fixes: 615510fe13bd2 ("thermal: devfreq_cooling: remove old power model and use EM")
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> 
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
>> ---
>>   drivers/thermal/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
>> index 7edc8dc6bbab..ee62d51ef351 100644
>> --- a/drivers/thermal/Kconfig
>> +++ b/drivers/thermal/Kconfig
>> @@ -193,6 +193,7 @@ config DEVFREQ_THERMAL
>>   	bool "Generic device cooling support"
>>   	depends on PM_DEVFREQ
>>   	depends on PM_OPP
>> +	depends on ENERGY_MODEL
>>   	help
>>   	  This implements the generic devfreq cooling mechanism through
>>   	  frequency reduction for devices using devfreq.
> 
> Looks good to me.
> 

My apologies. I've tested it on odroidxu3 with
exynos_defconfig which has the energy model set.

Reviewed-by: Lukasz Luba <lukasz.luba@....com>

Regards,
Lukasz