linux-kernel - Re: [PATCH] btrfs: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201215181332.GC6430@twin.jikos.cz>
Date:   Tue, 15 Dec 2020 19:13:32 +0100
From:   David Sterba <dsterba@...e.cz>
To:     kernel test robot <lkp@...el.com>
Cc:     Josef Bacik <josef@...icpanda.com>, kbuild-all@...ts.01.org,
        David Sterba <dsterba@...e.com>,
        Nikolay Borisov <nborisov@...e.com>,
        Chris Mason <chris.mason@...ionio.com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: fix boolreturn.cocci warnings

On Sun, Nov 01, 2020 at 01:20:51PM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@...el.com>
> 
> fs/btrfs/space-info.c:810:9-10: WARNING: return of 0/1 in function 'need_preemptive_reclaim' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> Fixes: fc96d3794eb2 ("btrfs: rename need_do_async_reclaim")
> CC: Josef Bacik <josef@...icpanda.com>
> Signed-off-by: kernel test robot <lkp@...el.com>

The patchset is still in a topic branch so I folded the change. There
were more int/bool mismatches in other patches, that got fixed too.