linux-kernel - Re: [PATCH v2] net: korina: fix return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e175246-5357-ccf6-6c7e-5f68089f30bf@gmail.com>
Date:   Wed, 16 Dec 2020 13:32:26 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Vincent Stehlé <vincent.stehle@...oste.net>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Julian Wiedmann <jwi@...ux.ibm.com>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2] net: korina: fix return value

On 12/16/20 12:43 PM, Jakub Kicinski wrote:
> On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote:
>> The ndo_start_xmit() method must not attempt to free the skb to transmit
>> when returning NETDEV_TX_BUSY. Therefore, make sure the
>> korina_send_packet() function returns NETDEV_TX_OK when it frees a packet.
>>
>> Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
>> Suggested-by: Jakub Kicinski <kuba@...nel.org>
>> Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
>> Cc: David S. Miller <davem@...emloft.net>
>> Cc: Florian Fainelli <florian.fainelli@...ecomint.eu>
> 
> Let me CC Florian's more recent email just in case he wants to review.

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian