linux-kernel - Re: [PATCH v2] proc: Escape more characters in /proc/mounts output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b13c0b71-dd3b-4a2b-1fc7-16d6fea36d46@gotplt.org>
Date:   Wed, 16 Dec 2020 10:55:16 +0530
From:   Siddhesh Poyarekar <siddhesh@...plt.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Florian Weimer <fweimer@...hat.com>
Subject: Re: [PATCH v2] proc: Escape more characters in /proc/mounts output

On 12/16/20 10:03 AM, Al Viro wrote:
> Once more, with feeling: why bother?  What's wrong
> with using the damn strndup_user() and then doing
> whatever checks you want with the data already
> copied, living in normal kernel memory, with all
> string functions applicable, etc.?

I was trying to avoid the allocation, but I reckon it is pointless to 
micro-optimize the invalid case.  I'll send v3.

Siddhesh