linux-kernel - Re: [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201216130548.GB4861@sirena.org.uk>
Date:   Wed, 16 Dec 2020 13:05:48 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Hsin-hsiung Wang <hsin-hsiung.wang@...iatek.com>
Cc:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        srv_heupstream@...iatek.com, Wen Su <wen.su@...iatek.com>
Subject: Re: [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359
 regulator

On Wed, Dec 16, 2020 at 12:34:19PM +0800, Hsin-hsiung Wang wrote:
> On Wed, 2020-09-23 at 17:24 +0100, Mark Brown wrote:
> > On Mon, Sep 21, 2020 at 07:48:10PM +0800, Hsin-Hsiung Wang wrote:

> > > +Required properties:
> > > +- compatible: "mediatek,mt6359-regulator"

> > The compatible isn't used by the driver (which is good!) so should be
> > dropped from the binding document.

> Thanks for your comments, but I have a question about it.
> When I remove the compatible name in the dts, there will be some error
> message:
> [    0.437562] mt6359-regulator: Failed to locate of_node [id: -1]
> [    0.440612] mt6359-sound: Failed to locate of_node [id: -1]

> Do you mean that we don't need any compatible name in dts, mfd and
> regulator driver?

The MFD driver and DT node for the MFD will need a compatible.  The
regulator function doesn't, it can just look things up based on the
parent.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)