linux-kernel - Re: [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1608093259.2412.1.camel@mtksdaap41>
Date:   Wed, 16 Dec 2020 12:34:19 +0800
From:   Hsin-hsiung Wang <hsin-hsiung.wang@...iatek.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Lee Jones <lee.jones@...aro.org>, Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <srv_heupstream@...iatek.com>,
        Wen Su <wen.su@...iatek.com>
Subject: Re: [PATCH v2 3/8] dt-bindings: regulator: Add document for MT6359
 regulator

Hi,

On Wed, 2020-09-23 at 17:24 +0100, Mark Brown wrote:
> On Mon, Sep 21, 2020 at 07:48:10PM +0800, Hsin-Hsiung Wang wrote:
> 
> > +Required properties:
> > +- compatible: "mediatek,mt6359-regulator"
> 
> The compatible isn't used by the driver (which is good!) so should be
> dropped from the binding document.
Thanks for your comments, but I have a question about it.
When I remove the compatible name in the dts, there will be some error
message:
[    0.437562] mt6359-regulator: Failed to locate of_node [id: -1]
[    0.440612] mt6359-sound: Failed to locate of_node [id: -1]

Do you mean that we don't need any compatible name in dts, mfd and
regulator driver?