linux-kernel - Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11B2A42A-8B23-4F6D-9736-A2823D4DFE2B@fb.com>
Date:   Wed, 16 Dec 2020 01:12:09 +0000
From:   Nick Terrell <terrelln@...com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Eric Biggers <ebiggers@...nel.org>,
        Nick Terrell <nickrterrell@...il.com>,
        "squashfs-devel@...ts.sourceforge.net" 
        <squashfs-devel@...ts.sourceforge.net>,
        Christoph Hellwig <hch@...radead.org>,
        Yann Collet <cyan@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-f2fs-devel@...ts.sourceforge.net" 
        <linux-f2fs-devel@...ts.sourceforge.net>,
        Petr Malat <oss@...at.biz>, "Chris Mason" <clm@...com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Niket Agarwal <niketa@...com>,
        Btrfs BTRFS <linux-btrfs@...r.kernel.org>,
        Johannes Weiner <jweiner@...com>
Subject: Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6



> On Dec 15, 2020, at 4:58 PM, Herbert Xu <herbert@...dor.apana.org.au> wrote:
> 
> On Wed, Dec 16, 2020 at 12:48:51AM +0000, Nick Terrell wrote:
>> 
>> Thanks for the advice! The first zstd patches went through Herbert’s tree, which is
>> why I’ve sent them this way.
> 
> Sorry, but I'm not touch these patches as Christoph's objections
> don't seem to have been addressed.

I believe I’ve addressed Christoph's objections. He suggested creating
a wrapper API to avoid changing callers upon the zstd update. I’ve done
that, the only difference between the current API, and the changes I’ve
proposed patch 1, is that I’ve changed the prefix from ZSTD_ to zstd_ to
avoid conflicts & confusion with the upstream zstd API.

Cristoph, if you get a chance to take a look at these patches, please let
me know what you think about the current iteration of patches, and if I’ve
addressed all of your concerns.

Best,
Nick