linux-kernel - Re: [PATCH v2 1/7] regulator: dt-bindings: remove useless properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201217234948.GA451916@robh.at.kernel.org>
Date:   Thu, 17 Dec 2020 17:49:48 -0600
From:   Rob Herring <robh@...nel.org>
To:     Adrien Grassein <adrien.grassein@...il.com>
Cc:     broonie@...nel.org, jagan@...rulasolutions.com,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, troy.kisky@...ndarydevices.com
Subject: Re: [PATCH v2 1/7] regulator: dt-bindings: remove useless properties

On Wed, Dec 16, 2020 at 12:56:33AM +0100, Adrien Grassein wrote:
> regulator-name is a generic property of the regulator.
> Don't repeat it here.

Yes, but the values aren't generic.

> 
> Signed-off-by: Adrien Grassein <adrien.grassein@...il.com>
> ---
>  .../regulator/nxp,pf8x00-regulator.yaml         | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> index a6c259ce9785..913532d0532e 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> @@ -36,12 +36,6 @@ properties:
>          description:
>            Properties for single LDO regulator.
>  
> -        properties:
> -          regulator-name:
> -            pattern: "^ldo[1-4]$"
> -            description:
> -              should be "ldo1", ..., "ldo4"
> -
>          unevaluatedProperties: false
>  
>        "^buck[1-7]$":
> @@ -51,11 +45,6 @@ properties:
>            Properties for single BUCK regulator.
>  
>          properties:
> -          regulator-name:
> -            pattern: "^buck[1-7]$"
> -            description:
> -              should be "buck1", ..., "buck7"
> -
>            nxp,ilim-ma:
>              $ref: "/schemas/types.yaml#/definitions/uint32"
>              minimum: 2100
> @@ -94,12 +83,6 @@ properties:
>          description:
>            Properties for single VSNVS regulator.
>  
> -        properties:
> -          regulator-name:
> -            pattern: "^vsnvs$"
> -            description:
> -              should be "vsnvs"
> -
>          unevaluatedProperties: false
>  
>      additionalProperties: false
> -- 
> 2.20.1
>