linux-kernel - Re: [PATCH v2 3/7] regulator: dt-bindings: pf8x00: fix nxp,phase-shift doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201217235106.GA454244@robh.at.kernel.org>
Date:   Thu, 17 Dec 2020 17:51:06 -0600
From:   Rob Herring <robh@...nel.org>
To:     Adrien Grassein <adrien.grassein@...il.com>
Cc:     broonie@...nel.org, jagan@...rulasolutions.com,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, troy.kisky@...ndarydevices.com
Subject: Re: [PATCH v2 3/7] regulator: dt-bindings: pf8x00: fix
 nxp,phase-shift doc

On Wed, Dec 16, 2020 at 12:56:35AM +0100, Adrien Grassein wrote:
> nxp,phase-shift is an enum so use enum format to describe it.
> Minimum and maximum values are also wrong.
> 
> Signed-off-by: Adrien Grassein <adrien.grassein@...il.com>
> ---
>  .../bindings/regulator/nxp,pf8x00-regulator.yaml | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> index 913532d0532e..1da724c6e2ba 100644
> --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml
> @@ -60,21 +60,13 @@ properties:
>  
>            nxp,phase-shift:
>              $ref: "/schemas/types.yaml#/definitions/uint32"
> -            minimum: 45
> -            maximum: 0
> +            minimum: 0
> +            maximum: 315

You can drop this. It's redundant with the enum.

> +            default: 0
> +            enum: [ 0, 45, 90, 135, 180, 225, 270, 315 ]
>              description:
>                BUCK regulators phase shift control in degrees.
>  
> -              Listed phase shift control values in degrees are,
> -              45
> -              90
> -              135
> -              180
> -              225
> -              270
> -              315
> -              0 (default)
> -
>          unevaluatedProperties: false
>  
>        "^vsnvs$":
> -- 
> 2.20.1
>