linux-kernel - Re: [PATCH] gdb: correct sys.path insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b92ec4f5-42ef-8d8c-bf37-90e1476b95e5@siemens.com>
Date:   Thu, 17 Dec 2020 09:10:52 +0100
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Cc:     Kieran Bingham <kbingham@...nel.org>,
        Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH] gdb: correct sys.path insertion

On 16.12.20 14:36, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> Perhaps something got moved around at some point, but the
> current path that gets inserted has "/scripts/gdb" twice,
> since the script is located in scripts/gdb/ already. Fix
> the path.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
>  scripts/gdb/vmlinux-gdb.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/vmlinux-gdb.py b/scripts/gdb/vmlinux-gdb.py
> index 4136dc2c59df..476da5b6a7ca 100644
> --- a/scripts/gdb/vmlinux-gdb.py
> +++ b/scripts/gdb/vmlinux-gdb.py
> @@ -13,7 +13,7 @@
>  
>  import os
>  
> -sys.path.insert(0, os.path.dirname(__file__) + "/scripts/gdb")
> +sys.path.insert(0, os.path.dirname(__file__))
>  
>  try:
>      gdb.parse_and_eval("0")
> 

How did you test that, which setup? I just ran "gdb
<linux>/build/vmlinux", and "python print(sys.path)" didn't expose this
duplication. So your change would actually break that common case.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux