linux-kernel - Re: [PATCH] gdb: correct sys.path insertion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <104d6f30adf16d30a8d85e0d0813a85ad563e09c.camel@sipsolutions.net>
Date:   Thu, 17 Dec 2020 09:14:00 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Jan Kiszka <jan.kiszka@...mens.com>, linux-kernel@...r.kernel.org
Cc:     Kieran Bingham <kbingham@...nel.org>
Subject: Re: [PATCH] gdb: correct sys.path insertion

Hi Jan,

> > -sys.path.insert(0, os.path.dirname(__file__) + "/scripts/gdb")
> > +sys.path.insert(0, os.path.dirname(__file__))
> >  
> >  try:
> >      gdb.parse_and_eval("0")
> > 
> 
> How did you test that, which setup? I just ran "gdb
> <linux>/build/vmlinux", and "python print(sys.path)" didn't expose this
> duplication. So your change would actually break that common case.

Oh, seems that was my mistake. I was trying to (explicitly) load the
file as "scripts/gdb/vmlinux-gdb.py" rather than using the symlink that
gets installed.

Never mind.

johannes