linux-kernel - Re: [PATCH v2 7/8] usb: host: ehci-tegra: Remove the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Dec 2020 22:43:33 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Peter Chen <Peter.Chen@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>,
        Matt Merhar <mattmerhar@...tonmail.com>,
        Nicolas Chauvet <kwizart@...il.com>,
        Peter Geis <pgwipeout@...il.com>,
        Ion Agorria <ion@...rria.com>, linux-tegra@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 7/8] usb: host: ehci-tegra: Remove the driver

17.12.2020 18:50, Alan Stern пишет:
> On Thu, Dec 17, 2020 at 12:40:06PM +0300, Dmitry Osipenko wrote:
>> The ChipIdea driver now provides USB2 host mode support for NVIDIA Tegra
>> SoCs. The ehci-tegra driver is obsolete now, remove it and redirect the
>> older Kconfig entry to the CI driver.
>>
>> Tested-by: Matt Merhar <mattmerhar@...tonmail.com>
>> Tested-by: Nicolas Chauvet <kwizart@...il.com>
>> Tested-by: Peter Geis <pgwipeout@...il.com>
>> Tested-by: Ion Agorria <ion@...rria.com>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  drivers/usb/host/Kconfig      |   8 +-
>>  drivers/usb/host/Makefile     |   1 -
>>  drivers/usb/host/ehci-tegra.c | 604 ----------------------------------
>>  3 files changed, 6 insertions(+), 607 deletions(-)
>>  delete mode 100644 drivers/usb/host/ehci-tegra.c
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index 31e59309da1f..318315602337 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -269,9 +269,13 @@ config USB_EHCI_HCD_AT91
>>  config USB_EHCI_TEGRA
>>  	tristate "NVIDIA Tegra HCD support"
>>  	depends on ARCH_TEGRA
>> -	select USB_EHCI_ROOT_HUB_TT
>> -	select USB_TEGRA_PHY
>> +	select USB_CHIPIDEA
>> +	select USB_CHIPIDEA_HOST
>> +	select USB_CHIPIDEA_TEGRA
>>  	help
>> +	  This option is deprecated now and the driver was removed, use
>> +	  USB_CHIPIDEA_TEGRA instead.
>> +
>>  	  This driver enables support for the internal USB Host Controllers
>>  	  found in NVIDIA Tegra SoCs. The controllers are EHCI compliant.
> 
> It doesn't really make sense to say "... the driver was removed..."
> and then in the next paragraph say "This driver enables...".  You
> should change the second paragraph to begin: "Enable support for...".
> 
> That's a minor matter, though, and you can easily fix it in the next
> patch version.  Everything else is okay.
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>

Okay, thanks.