linux-kernel - Re: [PATCH] clk: exynos7: Mark aclk_fsys1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61a6d576-9f91-dd2c-fd09-7e243f6ec7be@gmail.com>
Date:   Thu, 17 Dec 2020 22:08:50 +0100
From:   Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
To:     Stephen Boyd <sboyd@...nel.org>, kgene@...nel.org, krzk@...nel.org,
        mturquette@...libre.com
Cc:     s.nawrocki@...sung.com, tomasz.figa@...il.com,
        cw00.choi@...sung.com, linux-samsung-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: exynos7: Mark aclk_fsys1_200 as critical



On 17.12.2020 11:14, Stephen Boyd wrote:
> Not sure why this wasn't picked up in the samsung PR. Can you resend?
Hi
There was v2
(https://patchwork.kernel.org/project/linux-samsung-soc/patch/20201107121456.25562-1-pawel.mikolaj.chmiel@gmail.com/)
but it did receive some request for changes comments and i didn't yet
had time to it.

> 
>> diff --git a/drivers/clk/samsung/clk-exynos7.c b/drivers/clk/samsung/clk-exynos7.c
>> index c1ff715e960c..1048d83f097b 100644
>> --- a/drivers/clk/samsung/clk-exynos7.c
>> +++ b/drivers/clk/samsung/clk-exynos7.c
>> @@ -538,7 +538,8 @@ static const struct samsung_gate_clock top1_gate_clks[] __initconst = {
>>                 ENABLE_ACLK_TOP13, 28, CLK_SET_RATE_PARENT |
>>                 CLK_IS_CRITICAL, 0),
>>         GATE(CLK_ACLK_FSYS1_200, "aclk_fsys1_200", "dout_aclk_fsys1_200",
>> -               ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT, 0),
>> +               ENABLE_ACLK_TOP13, 24, CLK_SET_RATE_PARENT |
>> +               CLK_IS_CRITICAL, 0),
>>  
> 
> Please put a comment in the code why a clk is critica>