lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 14:09:15 +0800 From: Can Guo <cang@...eaurora.org> To: Stanley Chu <stanley.chu@...iatek.com> Cc: linux-scsi@...r.kernel.org, martin.petersen@...cle.com, avri.altman@....com, alim.akhtar@...sung.com, jejb@...ux.ibm.com, beanhuo@...ron.com, asutoshd@...eaurora.org, matthias.bgg@...il.com, bvanassche@....org, linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, kuohong.wang@...iatek.com, peter.wang@...iatek.com, chun-hung.wu@...iatek.com, andy.teng@...iatek.com, chaotian.jing@...iatek.com, cc.chou@...iatek.com, jiajie.hao@...iatek.com, alice.chao@...iatek.com Subject: Re: [PATCH v2 2/4] scsi: ufs: Remove redundant null checking of devfreq instance On 2020-12-16 21:16, Stanley Chu wrote: > hba->devfreq is zero-initialized thus it is not required > to check its existence in ufshcd_add_lus() function which > is invoked during initialization only. > > Signed-off-by: Stanley Chu <stanley.chu@...iatek.com> > --- > drivers/scsi/ufs/ufshcd.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index a91b73a1fc48..9cc16598136d 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -7636,15 +7636,13 @@ static int ufshcd_add_lus(struct ufs_hba *hba) > &hba->pwr_info, > sizeof(struct ufs_pa_layer_attr)); > hba->clk_scaling.saved_pwr_info.is_valid = true; > - if (!hba->devfreq) { > - hba->clk_scaling.is_allowed = true; > - ret = ufshcd_devfreq_init(hba); > - if (ret) > - goto out; > + hba->clk_scaling.is_allowed = true; > + ret = ufshcd_devfreq_init(hba); > + if (ret) > + goto out; > > - hba->clk_scaling.is_enabled = true; > - ufshcd_clkscaling_init_sysfs(hba); > - } > + hba->clk_scaling.is_enabled = true; > + ufshcd_clkscaling_init_sysfs(hba); > } > > ufs_bsg_probe(hba); Reviewed-by: Can Guo <cang@...eaurora.org>
Powered by blists - more mailing lists