lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Dec 2020 09:15:33 +0100 From: Stefano Garzarella <sgarzare@...hat.com> To: "Zouwei (Samuel)" <zou_wei@...wei.com> Cc: "mst@...hat.com" <mst@...hat.com>, "jasowang@...hat.com" <jasowang@...hat.com>, "mgurtovoy@...dia.com" <mgurtovoy@...dia.com>, "virtualization@...ts.linux-foundation.org" <virtualization@...ts.linux-foundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: 答复: [PATCH -next] vdpa: Mark macaddr_buf with static keyword On Fri, Dec 18, 2020 at 08:11:20AM +0000, Zouwei (Samuel) wrote: >Hi, >I run this command: >make allmodconfig ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- >make C=2 drivers/vdpa/vdpa_sim/vdpa_sim_net.o ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu- Yeah, I can see the warning using C=2. I'll use it next times. Thanks for sharing, Stefano > > >-----邮件原件----- >发件人: Stefano Garzarella [mailto:sgarzare@...hat.com] >发送时间: 2020年12月18日 15:57 >收件人: Zouwei (Samuel) <zou_wei@...wei.com> >抄送: mst@...hat.com; jasowang@...hat.com; mgurtovoy@...dia.com; virtualization@...ts.linux-foundation.org; linux-kernel@...r.kernel.org >主题: Re: [PATCH -next] vdpa: Mark macaddr_buf with static keyword > >On Fri, Dec 18, 2020 at 09:51:35AM +0800, Zou Wei wrote: >>Fix the following sparse warning: >> >>drivers/vdpa/vdpa_sim/vdpa_sim_net.c:36:4: warning: symbol 'macaddr_buf' was not declared. Should it be static? >> >>Reported-by: Hulk Robot <hulkci@...wei.com> >>Signed-off-by: Zou Wei <zou_wei@...wei.com> >>--- >> drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >Reviewed-by: Stefano Garzarella <sgarzare@...hat.com> > >I built with W=1 but I didn't have this warning. > >Thanks for fixing, >Stefano > >> >>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >>b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >>index c10b698..f048242 100644 >>--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c >>@@ -33,7 +33,7 @@ static char *macaddr; module_param(macaddr, charp, >>0); MODULE_PARM_DESC(macaddr, "Ethernet MAC address"); >> >>-u8 macaddr_buf[ETH_ALEN]; >>+static u8 macaddr_buf[ETH_ALEN]; >> >> static struct vdpasim *vdpasim_net_dev; >> >>-- >>2.6.2 >> >
Powered by blists - more mailing lists