linux-kernel - Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Dec 2020 10:36:41 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     "Alice Guo (OSS)" <alice.guo@....nxp.com>
Cc:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for
 soc unique ID

On Fri, Dec 18, 2020 at 09:05:00AM +0000, Alice Guo (OSS) wrote:
 > > +    required:
> > > +      - compatible
> > > +      - nvmem-cells
> > > +      - nvmem-cell-names
> > > +
> > > +additionalProperties: true
> > 
> > Don't leave comments unresolved (or resolve them against review without
> > discussion). Rob asked for changing it. The same as with all schemas - you need
> > to describe the missing properties.
> > 
> > Best regards,
> > Krzysztof
> 
> Hi,
> Thank you for your advice. I replied to him and let him know I remained here unchanged. There will be errors according to his suggestion.

Then the solution is to correct the errors - describe missing properties
- instead of ignoring the suggestion and making a resubmit right away.

Best regards,
Krzysztof