linux-kernel - Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201218113209.GD325926@kernel.org>
Date:   Fri, 18 Dec 2020 08:32:09 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.ibm.com>,
        "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
Cc:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH 3/4] perf tools: Update powerpc's syscall.tbl

Em Fri, Dec 18, 2020 at 08:26:59AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Dec 18, 2020 at 03:59:23PM +0800, Tiezhu Yang escreveu:
> > This silences the following tools/perf/ build warning:
> > Warning: Kernel ABI header at 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl'
> 
> Hi Ravi, Naveen,
> 
> 	Can I get your Reviewed-by or Acked-by for this change and the
> other that adds s390's syscall.tbl to check_headers.sh so that we get

oops s/s390/powerpc/g :-)

> notified when the copy drifts, so that we can see if it still continues
> working and we can get new syscalls to be supported in things like 'perf
> trace'?
> 
> Thanks,
> 
> - Arnaldo
>  
> > Just make them same:
> > cp arch/powerpc/kernel/syscalls/syscall.tbl tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> > 
> > Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> > ---
> >  tools/perf/arch/powerpc/entry/syscalls/syscall.tbl | 25 ++++++++++++++++------
> >  1 file changed, 18 insertions(+), 7 deletions(-)
> > 
> > diff --git a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> > index b168364..1275dae 100644
> > --- a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> > +++ b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> > @@ -9,7 +9,9 @@
> >  #
> >  0	nospu	restart_syscall			sys_restart_syscall
> >  1	nospu	exit				sys_exit
> > -2	nospu	fork				ppc_fork
> > +2	32	fork				ppc_fork			sys_fork
> > +2	64	fork				sys_fork
> > +2	spu	fork				sys_ni_syscall
> >  3	common	read				sys_read
> >  4	common	write				sys_write
> >  5	common	open				sys_open			compat_sys_open
> > @@ -158,7 +160,9 @@
> >  119	32	sigreturn			sys_sigreturn			compat_sys_sigreturn
> >  119	64	sigreturn			sys_ni_syscall
> >  119	spu	sigreturn			sys_ni_syscall
> > -120	nospu	clone				ppc_clone
> > +120	32	clone				ppc_clone			sys_clone
> > +120	64	clone				sys_clone
> > +120	spu	clone				sys_ni_syscall
> >  121	common	setdomainname			sys_setdomainname
> >  122	common	uname				sys_newuname
> >  123	common	modify_ldt			sys_ni_syscall
> > @@ -240,7 +244,9 @@
> >  186	spu	sendfile			sys_sendfile64
> >  187	common	getpmsg				sys_ni_syscall
> >  188	common 	putpmsg				sys_ni_syscall
> > -189	nospu	vfork				ppc_vfork
> > +189	32	vfork				ppc_vfork			sys_vfork
> > +189	64	vfork				sys_vfork
> > +189	spu	vfork				sys_ni_syscall
> >  190	common	ugetrlimit			sys_getrlimit			compat_sys_getrlimit
> >  191	common	readahead			sys_readahead			compat_sys_readahead
> >  192	32	mmap2				sys_mmap2			compat_sys_mmap2
> > @@ -316,8 +322,8 @@
> >  248	32	clock_nanosleep			sys_clock_nanosleep_time32
> >  248	64	clock_nanosleep			sys_clock_nanosleep
> >  248	spu	clock_nanosleep			sys_clock_nanosleep
> > -249	32	swapcontext			ppc_swapcontext			ppc32_swapcontext
> > -249	64	swapcontext			ppc64_swapcontext
> > +249	32	swapcontext			ppc_swapcontext			compat_sys_swapcontext
> > +249	64	swapcontext			sys_swapcontext
> >  249	spu	swapcontext			sys_ni_syscall
> >  250	common	tgkill				sys_tgkill
> >  251	32	utimes				sys_utimes_time32
> > @@ -456,7 +462,7 @@
> >  361	common	bpf				sys_bpf
> >  362	nospu	execveat			sys_execveat			compat_sys_execveat
> >  363	32	switch_endian			sys_ni_syscall
> > -363	64	switch_endian			ppc_switch_endian
> > +363	64	switch_endian			sys_switch_endian
> >  363	spu	switch_endian			sys_ni_syscall
> >  364	common	userfaultfd			sys_userfaultfd
> >  365	common	membarrier			sys_membarrier
> > @@ -516,6 +522,11 @@
> >  432	common	fsmount				sys_fsmount
> >  433	common	fspick				sys_fspick
> >  434	common	pidfd_open			sys_pidfd_open
> > -435	nospu	clone3				ppc_clone3
> > +435	32	clone3				ppc_clone3			sys_clone3
> > +435	64	clone3				sys_clone3
> > +435	spu	clone3				sys_ni_syscall
> > +436	common	close_range			sys_close_range
> >  437	common	openat2				sys_openat2
> >  438	common	pidfd_getfd			sys_pidfd_getfd
> > +439	common	faccessat2			sys_faccessat2
> > +440	common	process_madvise			sys_process_madvise
> > -- 
> > 2.1.0
> > 
> 
> -- 
> 
> - Arnaldo

-- 

- Arnaldo