linux-kernel - Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31aac1e5-e0de-c4e3-ebf1-13d682472083@gmail.com>
Date:   Fri, 18 Dec 2020 09:34:11 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     matthias.bgg@...nel.org, mpm@...enic.com,
        herbert@...dor.apana.org.au, rjui@...adcom.com,
        sbranden@...adcom.com
Cc:     linux-kernel@...r.kernel.org, Julia.Lawall@...ia.fr,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, nsaenzjulienne@...e.de,
        linux-crypto@...r.kernel.org, Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.

On 12/18/20 2:57 AM, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <mbrugger@...e.com>
> 
> When trying to disable the block we bitwise or the control
> register with value zero. This is confusing as using bitwise or with
> value zero doesn't have any effect at all. Drop this as we already set
> the enable bit to zero by appling inverted RNG_RBGEN_MASK.
> 
> Signed-off-by: Matthias Brugger <mbrugger@...e.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian