linux-kernel - RE: Re: [PATCH v16 1/3] scsi: ufs: Introduce HPB feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201221023506epcms2p68be86df197976d1da2775f93709659c6@epcms2p6>
Date:   Mon, 21 Dec 2020 11:35:06 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Daejun Park <daejun7.park@...sung.com>
CC:     "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "huobean@...il.com" <huobean@...il.com>,
        "bvanassche@....org" <bvanassche@....org>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Adel Choi <adel.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>
Subject: RE: Re: [PATCH v16 1/3] scsi: ufs: Introduce HPB feature

Hi Greg,

> > +static void ufshpb_hpb_lu_prepared(struct ufs_hba *hba)
> > +{
> > +	struct ufshpb_lu *hpb;
> > +	struct scsi_device *sdev;
> > +	bool init_success;
> > +
> > +	init_success = !ufshpb_check_hpb_reset_query(hba);
> > +
> > +	shost_for_each_device(sdev, hba->host) {
> > +		hpb = sdev->hostdata;
> > +		if (!hpb)
> > +			continue;
> > +
> > +		if (init_success) {
> > +			dev_info(hba->dev, "set state to present\n");
> 
> Why be noisy?  Why does userspace need to see this all the time,
> shouldn't only errors be printing something?

I will remove needless dev_info printings in this patch.

Thanks,
Daejun