linux-kernel - RE: [PATCH v8 4/4] soc: imx8m: change to use platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Dec 2020 02:36:15 +0000
From:   "Alice Guo (OSS)" <alice.guo@....nxp.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "Alice Guo (OSS)" <alice.guo@....nxp.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH v8 4/4] soc: imx8m: change to use platform driver



> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: 2020年12月19日 20:18
> To: Alice Guo (OSS) <alice.guo@....nxp.com>
> Cc: robh+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; festevam@...il.com; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>
> Subject: Re: [PATCH v8 4/4] soc: imx8m: change to use platform driver
> 
> On Fri, Dec 18, 2020 at 04:37:26PM +0800, Alice Guo (OSS) wrote:
> > From: Alice Guo <alice.guo@....com>
> >
> > Directly reading ocotp register depends on that bootloader enables
> > ocotp clk, which is not always effective, so change to use nvmem API.
> > Using nvmem API requires to support driver defer probe and thus change
> > soc-imx8m.c to use platform driver.
> >
> > The other reason is that directly reading ocotp register causes kexec
> > kernel hang because the 1st kernel running will disable unused clks
> > after kernel boots up, and then ocotp clk will be disabled even if
> > bootloader enables it. When kexec kernel, ocotp clk needs to be
> > enabled before reading ocotp registers, and nvmem API with platform
> > driver supported can accomplish this.
> >
> > Signed-off-by: Alice Guo <alice.guo@....com>
> > ---
> > Changes for v8:
> >  - none
> > Changes for v7:
> >  - solve the problem "drivers/soc/imx/soc-imx8m.c:174:34: warning:
> >    unused variable"
> 
> There was a reviewed-by part of changelog. The tag was in your commit.
> I am now confused, as changes for v8 say "none"... but shall I trust it?
> 
> Best regards,
> Krzysztof

Hi,
I forgot to add reviewed-by.

Best regards,
Alice