linux-kernel - Re: [PATCH] Kernel: Fixed two bracket problems in fork.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201221184204.3xq4qgn5z4nnfk5e@wittgenstein>
Date:   Mon, 21 Dec 2020 19:42:04 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Alexander Guril <alexander.guril02@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Kernel: Fixed two bracket problems in fork.c

On Mon, Dec 21, 2020 at 04:05:02PM +0100, Alexander Guril wrote:
> This fixes two bracket problems in kernel/fork.c
> 
> Signed-off-by: Alexander Guril <alexander.guril02@...il.com>
> ---

Thanks for the patch.
Unfortunately, there's no real rationale for the change in the commit
message. You probably want to mention that our coding-style mandates
that we don't use {} around single-line statements.

Christian

>  kernel/fork.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 41906a52a764..3a5301867297 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -819,9 +819,8 @@ void __init fork_init(void)
>  	init_task.signal->rlim[RLIMIT_SIGPENDING] =
>  		init_task.signal->rlim[RLIMIT_NPROC];
>  
> -	for (i = 0; i < UCOUNT_COUNTS; i++) {
> +	for (i = 0; i < UCOUNT_COUNTS; i++)
>  		init_user_ns.ucount_max[i] = max_threads/2;
> -	}
>  
>  #ifdef CONFIG_VMAP_STACK
>  	cpuhp_setup_state(CPUHP_BP_PREPARE_DYN, "fork:vm_stack_cache",
> @@ -1654,9 +1653,8 @@ static inline void init_task_pid_links(struct task_struct *task)
>  {
>  	enum pid_type type;
>  
> -	for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type) {
> +	for (type = PIDTYPE_PID; type < PIDTYPE_MAX; ++type)
>  		INIT_HLIST_NODE(&task->pid_links[type]);
> -	}
>  }
>  
>  static inline void
> -- 
> 2.29.2
>