lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 23 Dec 2020 13:08:21 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     trix@...hat.com
Cc:     netanel@...zon.com, akiyano@...zon.com, gtzalik@...zon.com,
        saeedb@...zon.com, zorik@...zon.com, davem@...emloft.net,
        sameehj@...zon.com, shayagr@...zon.com, amitbern@...zon.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ena: remove h from printk format specifier

On Wed, 23 Dec 2020 11:31:44 -0800 trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
> 
> Standard integer promotion is already done and %hx and %hhx is useless
> so do not encourage the use of %hh[xudi] or %h[xudi].
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

This really is not a change worth making in existing code, IMO.

I find it a little ironic that nacking of unnecessary code churn has
spawned unnecessary code churn in the opposite direction.

I'd leave it up to maintainers of specific drivers to decide, but for
now - net-next is closed anyway, please come back with these after
merge window is over.

Thanks!

Powered by blists - more mailing lists