linux-kernel - Re: [PATCH] erofs: support direct IO for uncompressed file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc4452e9-83eb-90e7-f001-d39d0ecdd105@oppo.com>
Date:   Wed, 23 Dec 2020 16:48:20 +0800
From:   Huang Jianan <huangjianan@...o.com>
To:     Christoph Hellwig <hch@...radead.org>,
        Gao Xiang <hsiangkao@...hat.com>
Cc:     guoweichao@...o.com, linux-erofs@...ts.ozlabs.org,
        zhangshiming@...o.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] erofs: support direct IO for uncompressed file

Hi Christoph,

The reason we use dio is because we need to deploy the patch on some 
early kernel versions, and we don't pay much attention to the change of 
iomap. Anyway, I will study the problem mentioned by Gao Xiang and try 
to convert the current patch to iomap.

Thanks,

Jianan

> On Wed, Dec 23, 2020 at 03:39:01AM +0800, Gao Xiang wrote:
>> Hi Christoph,
>>
>> On Tue, Dec 22, 2020 at 02:22:34PM +0000, Christoph Hellwig wrote:
>>> Please do not add new callers of __blockdev_direct_IO and use the modern
>>> iomap variant instead.
>> We've talked about this topic before. The current status is that iomap
>> doesn't support tail-packing inline data yet (Chao once sent out a version),
>> and erofs only cares about read intrastructure for now (So we don't think
>> more about how to deal with tail-packing inline write path). Plus, the
>> original patch was once lack of inline data regression test from gfs2 folks.
> So resend Chaos prep patch as part of the series switching parts of
> erofs to iomap.  We need to move things off the old infrastructure instead
> of adding more users and everyone needs to help a little.