linux-kernel - Re: [PATCH net] net: ethernet: ti: cpts: fix ethtool output when no ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201228133309.7d0c1047@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 28 Dec 2020 13:33:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Richard Cochran <richardcochran@...il.com>,
        Grygorii Strashko <grygorii.strashko@...com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vignesh Raghavendra <vigneshr@...com>,
        Lokesh Vutla <lokeshvutla@...com>
Subject: Re: [PATCH net] net: ethernet: ti: cpts: fix ethtool output when no
 ptp_clock registered

On Thu, 24 Dec 2020 13:21:36 -0800 Richard Cochran wrote:
> On Thu, Dec 24, 2020 at 06:24:05PM +0200, Grygorii Strashko wrote:
> > The CPTS driver registers PTP PHC clock when first netif is going up and
> > unregister it when all netif are down. Now ethtool will show:
> >  - PTP PHC clock index 0 after boot until first netif is up;
> >  - the last assigned PTP PHC clock index even if PTP PHC clock is not
> > registered any more after all netifs are down.
> > 
> > This patch ensures that -1 is returned by ethtool when PTP PHC clock is not
> > registered any more.
> > 
> > Fixes: 8a2c9a5ab4b9 ("net: ethernet: ti: cpts: rework initialization/deinitialization")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>  
> 
> Acked-by: Richard Cochran <richardcochran@...il.com>

Applied, thank you!