lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Dec 2020 22:47:51 +0200 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Cc: Daniel Scally <djrscally@...il.com>, Sakari Ailus <sakari.ailus@...ux.intel.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, ACPI Devel Maling List <linux-acpi@...r.kernel.org>, Linux Media Mailing List <linux-media@...r.kernel.org>, devel@...ica.org, "Rafael J. Wysocki" <rjw@...ysocki.net>, Len Brown <lenb@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Yong Zhi <yong.zhi@...el.com>, Bingbu Cao <bingbu.cao@...el.com>, Tian Shu Qiu <tian.shu.qiu@...el.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Robert Moore <robert.moore@...el.com>, Erik Kaneda <erik.kaneda@...el.com>, Petr Mladek <pmladek@...e.com>, Steven Rostedt <rostedt@...dmis.org>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, Jacopo Mondi <jacopo+renesas@...ndi.org>, kieran.bingham+renesas@...asonboard.com, Hans Verkuil <hverkuil-cisco@...all.nl>, Marco Felsch <m.felsch@...gutronix.de>, niklas.soderlund+renesas@...natech.se, Steve Longerbeam <slongerbeam@...il.com>, "Krogerus, Heikki" <heikki.krogerus@...ux.intel.com>, Linus Walleij <linus.walleij@...aro.org>, Jordan Hand <jorhand@...ux.microsoft.com> Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver On Tue, Dec 29, 2020 at 2:07 AM Laurent Pinchart <laurent.pinchart@...asonboard.com> wrote: > On Tue, Dec 29, 2020 at 01:54:59AM +0200, Andy Shevchenko wrote: > > On Tue, Dec 29, 2020 at 1:08 AM Laurent Pinchart wrote: ... > > +#include <linux/videodev2.h> > > I think this can be dropped. I dropped above (I noticed it's included by a half of the headers listed below. > > +#include <media/media-device.h> > > +#include <media/media-entity.h> > > +#include <media/v4l2-async.h> > > +#include <media/v4l2-dev.h> > > +#include <media/v4l2-device.h> > > +#include <media/v4l2-subdev.h> > > +#include <media/videobuf2-core.h> > > +#include <media/videobuf2-v4l2.h> ... > How about grouping all forward declarations at the top ? Done. > Otherwise this looks good, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com> Thanks! I just sent a formal patch with your tag included. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists