lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 2 Jan 2021 19:07:31 +0200
From:   Sakari Ailus <>
To:     Daniel Scally <>
Cc:     Andy Shevchenko <>,
        Linux Kernel Mailing List <>,
        ACPI Devel Maling List <>,
        Linux Media Mailing List <>,, "Rafael J. Wysocki" <>,
        Len Brown <>,
        Greg Kroah-Hartman <>,
        Yong Zhi <>,
        Bingbu Cao <>,
        Tian Shu Qiu <>,
        Mauro Carvalho Chehab <>,
        Robert Moore <>,
        Erik Kaneda <>,
        Petr Mladek <>,
        Steven Rostedt <>,
        Sergey Senozhatsky <>,
        Andy Shevchenko <>,
        Rasmus Villemoes <>,
        Laurent Pinchart <>,
        Jacopo Mondi <>,,
        Hans Verkuil <>,
        Marco Felsch <>,,
        Steve Longerbeam <>,
        "Krogerus, Heikki" <>,
        Linus Walleij <>,
        Jordan Hand <>,
        Laurent Pinchart <>
Subject: Re: [PATCH v3 14/14] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver

Hi Daniel,

On Mon, Dec 28, 2020 at 10:37:38PM +0000, Daniel Scally wrote:
> >>> +#define CIO2_NUM_PORTS                         4
> > 
> > This is already defined in ipu3-cio2.h. Could you include that instead?
> Yes; but I'd need to also include media/v4l2-device.h and
> media/videobuf2-dma-sg.h (they're included in ipu3-cio2-main.c at the
> moment). It didn't seem worth it; but I can move those two includes from
> the .c to the .h and then include ipu3-cio2.h in cio2-bridge.h
> Which do you prefer?

Seems you got answers already... :-) splitting the header in two seems good
to me. But IMO it doesn't have to be a part of this set.

Sakari Ailus

Powered by blists - more mailing lists