linux-kernel - Re: [PATCH 4.19 267/346] ALSA: hda/ca0132

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201231181542.GA28026@amd>
Date:   Thu, 31 Dec 2020 19:15:42 +0100
From:   Pavel Machek <pavel@....cz>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        stable@...nel.org, Connor McAdams <conmanx360@...il.com>,
        Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 4.19 267/346] ALSA: hda/ca0132 - Change Input Source enum
 strings.

Hi!

> From: Connor McAdams <conmanx360@...il.com>
> 
> commit 7079f785b50055a32b72eddcb7d9ba5688db24d0 upstream.
> 
> Change the Input Source enumerated control's strings to make it play
> nice with pulseaudio.

> +++ b/sound/pci/hda/patch_ca0132.c
> @@ -106,7 +106,7 @@ enum {
>  };
>  
>  /* Strings for Input Source Enum Control */
> -static const char *const in_src_str[3] = {"Rear Mic", "Line", "Front Mic" };
> +static const char *const in_src_str[3] = { "Microphone", "Line In", "Front Microphone" };
>  #define IN_SRC_NUM_OF_INPUTS 3

If pulseaudio expects the strings to be from small set, should we have
defines for them?

If pulseaudio can't understand short versions, do these need fixing,
too?

hda_auto_parser.c:		"Internal Mic", "Dock Mic", "Mic", "Rear Mic", "Front Mic"
hda_auto_parser.c:			return "Headset Mic";
hda_auto_parser.c:			return "Headphone Mic";
hda_auto_parser.c:			return "Mic";
hda_auto_parser.c:		return "Headphone Mic";
hda_jack.c:						    cfg, "Headphone Mic");
hda_jack.c:						    cfg, "Headphone Mic");
hda_proc.c:		"Line In", "Aux", "Mic", "Telephony",

Best regards,
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)