linux-kernel - Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210102220832.GO12767@gondor.apana.org.au>
Date:   Sun, 3 Jan 2021 09:08:32 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     matthias.bgg@...nel.org
Cc:     mpm@...enic.com, rjui@...adcom.com, sbranden@...adcom.com,
        f.fainelli@...il.com, linux-kernel@...r.kernel.org,
        Julia.Lawall@...ia.fr, bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, nsaenzjulienne@...e.de,
        linux-crypto@...r.kernel.org, Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v2 1/2] hwrng: iproc-rng200: Fix disable of the block.

On Fri, Dec 18, 2020 at 11:57:07AM +0100, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <mbrugger@...e.com>
> 
> When trying to disable the block we bitwise or the control
> register with value zero. This is confusing as using bitwise or with
> value zero doesn't have any effect at all. Drop this as we already set
> the enable bit to zero by appling inverted RNG_RBGEN_MASK.
> 
> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
> 
> ---
> 
> Changes in v2:
> - fix commit message, dropping Fixes tag
> - drop inverted RNT_RBGEN_ENABLE in disable case
> 
>  drivers/char/hw_random/iproc-rng200.c | 3 ---
>  1 file changed, 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt