linux-kernel - Re: [PATCH v2 2/2] hwrng: iproc-rng200: Move enable/disable in separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210102220842.GP12767@gondor.apana.org.au>
Date:   Sun, 3 Jan 2021 09:08:42 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     matthias.bgg@...nel.org
Cc:     mpm@...enic.com, rjui@...adcom.com, sbranden@...adcom.com,
        f.fainelli@...il.com, linux-kernel@...r.kernel.org,
        Julia.Lawall@...ia.fr, bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org, nsaenzjulienne@...e.de,
        linux-crypto@...r.kernel.org, Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v2 2/2] hwrng: iproc-rng200: Move enable/disable in
 separate function

On Fri, Dec 18, 2020 at 11:57:08AM +0100, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <mbrugger@...e.com>
> 
> We are calling the same code for enable and disable the block in various
> parts of the driver. Put that code into a new function to reduce code
> duplication.
> 
> Signed-off-by: Matthias Brugger <mbrugger@...e.com>
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> 
> ---
> 
> Changes in v2:
> - rename function to iproc_rng200_enable_set()
> - use u32 value instead of uint32_t
> 
>  drivers/char/hw_random/iproc-rng200.c | 35 ++++++++++++---------------
>  1 file changed, 16 insertions(+), 19 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt