linux-kernel - Re: [PATCH v5 3/5] crypto: expose elliptic curve parameters as Crypto APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a260ceec-e3ca-8fbd-e80e-f08ddc2029a4@huawei.com>
Date:   Mon, 4 Jan 2021 17:36:33 +0800
From:   yumeng <yumeng18@...wei.com>
To:     Daniele Alessandrelli <daniele.alessandrelli@...el.com>
CC:     <davem@...emloft.net>, <linux-crypto@...r.kernel.org>,
        <xuzaibo@...wei.com>, <wangzhou1@...ilicon.com>,
        <linux-kernel@...r.kernel.org>,
        Mark Gross <mgross@...ux.intel.com>,
        "Prabhjot Khurana" <prabhjot.khurana@...el.com>,
        Elena Reshetova <elena.reshetova@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH v5 3/5] crypto: expose elliptic curve parameters as Crypto
 APIs



在 2021/1/3 5:29, Herbert Xu 写道:
> On Thu, Dec 24, 2020 at 02:08:25PM +0800, Meng Yu wrote:
>> Move elliptic curves definition to 'include/crypto/ecc_curve_defs.h',
>> so all can use it,
>>
>> Signed-off-by: Meng Yu <yumeng18@...wei.com>
>> Reviewed-by: Zaibo Xu <xuzaibo@...wei.com>
>> ---
>>   crypto/ecc.c                    |  1 -
>>   crypto/ecc.h                    | 37 +----------------
>>   crypto/ecc_curve_defs.h         | 57 -------------------------
>>   crypto/ecrdsa_defs.h            |  2 +-
>>   include/crypto/ecc_curve_defs.h | 92 +++++++++++++++++++++++++++++++++++++++++
>>   5 files changed, 95 insertions(+), 94 deletions(-)
>>   delete mode 100644 crypto/ecc_curve_defs.h
>>   create mode 100644 include/crypto/ecc_curve_defs.h
> 
> This conflicts with
> 
> https://patchwork.kernel.org/project/linux-crypto/patch/20201217172101.381772-3-daniele.alessandrelli@linux.intel.com/
> 
> Please discuss with each other on how you would like to proceed.
> 
> Thanks,
> 

hello, Daniele,

In my patch, I move elliptic curves definition to 
'include/crypto/ecc_curve_defs.h',
which include the P-384 curve you need, and you can easily import it to 
your driver.

And if you include 'crypto/ecc_curve_defs.h', 
'drivers/crypto/keembay/ocs-ecc-curve-defs.h'
is not needed.

Could you think about it, to rely on my patchset?