linux-kernel - Re: [PATCH v5 3/5] crypto: expose elliptic curve parameters as Crypto APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Jan 2021 11:36:57 +0000
From:   "Alessandrelli, Daniele" <daniele.alessandrelli@...el.com>
To:     "yumeng18@...wei.com" <yumeng18@...wei.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>
CC:     "Khurana, Prabhjot" <prabhjot.khurana@...el.com>,
        "Reshetova, Elena" <elena.reshetova@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xuzaibo@...wei.com" <xuzaibo@...wei.com>,
        "wangzhou1@...ilicon.com" <wangzhou1@...ilicon.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH v5 3/5] crypto: expose elliptic curve parameters as Crypto
 APIs

On Mon, 2021-01-04 at 17:36 +0800, yumeng wrote:
> 
> 在 2021/1/3 5:29, Herbert Xu 写道:
> > On Thu, Dec 24, 2020 at 02:08:25PM +0800, Meng Yu wrote:
> > > Move elliptic curves definition to 'include/crypto/ecc_curve_defs.h',
> > > so all can use it,
> > > 
> > > Signed-off-by: Meng Yu <yumeng18@...wei.com>
> > > Reviewed-by: Zaibo Xu <xuzaibo@...wei.com>
> > > ---
> > >   crypto/ecc.c                    |  1 -
> > >   crypto/ecc.h                    | 37 +----------------
> > >   crypto/ecc_curve_defs.h         | 57 -------------------------
> > >   crypto/ecrdsa_defs.h            |  2 +-
> > >   include/crypto/ecc_curve_defs.h | 92 +++++++++++++++++++++++++++++++++++++++++
> > >   5 files changed, 95 insertions(+), 94 deletions(-)
> > >   delete mode 100644 crypto/ecc_curve_defs.h
> > >   create mode 100644 include/crypto/ecc_curve_defs.h
> > 
> > This conflicts with
> > 
> > https://patchwork.kernel.org/project/linux-crypto/patch/20201217172101.381772-3-daniele.alessandrelli@linux.intel.com/
> > 
> > Please discuss with each other on how you would like to proceed.
> > 
> > Thanks,
> > 
> 
> hello, Daniele,
> 
> In my patch, I move elliptic curves definition to 
> 'include/crypto/ecc_curve_defs.h',
> which include the P-384 curve you need, and you can easily import it to 
> your driver.
> 
> And if you include 'crypto/ecc_curve_defs.h', 
> 'drivers/crypto/keembay/ocs-ecc-curve-defs.h'
> is not needed.
> 
> Could you think about it, to rely on my patchset?

Hi Meng,

Sure, I can update my RFC patch series to rely on your patchset. It
makes sense to do so, since, as you said, it will allow me to get rid
of my ocs-ecc-curve-defs.h (and also because your patchset will
probably be merged before mine).

Herbert, should I send an updated RFC now or should I wait for the
discussion on the RFC open points to be completed first?

Thanks,
Daniele