linux-kernel - Re: [PATCH] [v2]net:ppp: remove disc_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210104102927.2712cc10@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 4 Jan 2021 10:29:27 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Gao Yan <gao.yanB@....com>
Cc:     <gregkh@...uxfoundation.org>, <jirislaby@...nel.org>,
        <paulus@...ba.org>, <davem@...emloft.net>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2]net:ppp: remove disc_data_lock in ppp line
 discipline

On Fri, 1 Jan 2021 11:37:18 +0800 Gao Yan wrote:
> In tty layer, it provides tty->ldisc_sem to protect all tty_ldisc_ops
> including ppp_sync_ldisc. So I think tty->ldisc_sem can also
> protect tty->disc_data, and the disc_data_lock is not necessary.
> 
> Signed-off-by: Gao Yan <gao.yanB@....com>

Please make sure to CC netdev.