linux-kernel - Re: [PATCH] arm64/smp: Remove unused variable irq in arch_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8deed54d-d184-69b8-fce9-d87128a7d880@arm.com>
Date:   Tue, 5 Jan 2021 16:39:15 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Catalin Marinas <catalin.marinas@....com>,
        Keqian Zhu <zhukeqian1@...wei.com>
Cc:     Mark Rutland <mark.rutland@....com>, kvm@...r.kernel.org,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Marc Zyngier <maz@...nel.org>, Joerg Roedel <joro@...tes.org>,
        linux-kernel@...r.kernel.org, James Morse <james.morse@....com>,
        Julien Thierry <julien.thierry.kdev@...il.com>,
        wanghaibin.wang@...wei.com, Will Deacon <will@...nel.org>,
        kvmarm@...ts.cs.columbia.edu, linux-arm-kernel@...ts.infradead.org,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH] arm64/smp: Remove unused variable irq in
 arch_show_interrupts()



On 1/5/21 3:38 PM, Catalin Marinas wrote:
> On Tue, Jan 05, 2021 at 05:22:21PM +0800, Keqian Zhu wrote:
>> The local variable irq is added in commit a26388152531 ("arm64:
>> Remove custom IRQ stat accounting"), but forget to remove in
>> commit 5089bc51f81f ("arm64/smp: Use irq_desc_kstat_cpu() in
>> arch_show_interrupts()"). Just remove it.
>>
>> Signed-off-by: Keqian Zhu <zhukeqian1@...wei.com>
> 
> I already queued a similar fix in arm64 for-next/fixes (it should appear
> in linux-next at some point)

I too sent this fix yesterday as well :) as it was preventing a clean
build on v5.11-rc2. Missed to check this on arm64 for-next/fixes though
I did check on linux-next.