linux-kernel - Re: [PATCH 0/5] Introduce the for_each_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jan 2021 12:09:41 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Syed Nayyar Waris <syednwaris@...il.com>,
        <linus.walleij@...aro.org>,
        Srinivas Neeli <srinivas.neeli@...inx.com>
CC:     <andriy.shevchenko@...ux.intel.com>, <vilhelm.gray@...il.com>,
        <michal.simek@...inx.com>, <arnd@...db.de>, <rrichter@...vell.com>,
        <bgolaszewski@...libre.com>, <yamada.masahiro@...ionext.com>,
        <akpm@...ux-foundation.org>, <rui.zhang@...el.com>,
        <daniel.lezcano@...aro.org>, <amit.kucheria@...durent.com>,
        <linux-arch@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 0/5] Introduce the for_each_set_clump macro

Hi,

On 26. 12. 20 7:41, Syed Nayyar Waris wrote:
> Hello Linus,
> 
> Since this patchset primarily affects GPIO drivers, would you like
> to pick it up through your GPIO tree?
> 
> (Note: Patchset resent with the new macro and relevant
> functions shifted to a new header clump_bits.h [Linus Torvalds])
> 
> Michal,
> What do you think of [PATCH 5/5]? Is the conditional check needed? And
> also does returning -EINVAL look good?

As was said would be better to handle it out of this series. And I
expect none is really describing fpga designs by hand and using DT
generator for it. But I can't see any issue with checking that we are
not exceeding certain limit.
Just keep in your mind that every bank has max 32 lines.
It means if you say bank0 40, bank1 10 which is in total 50 it will pass
your condition in 5/5.
It means maybe checking every bank separately is better approach.

Thanks,
Michal