linux-kernel - Re: [PATCH] fs: binfmt_em86: check return code of remove_arg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=4Ym1JR-PJDTgAgYe2mKFy1_LEkhNbxvThz-6JcShdnQ@mail.gmail.com>
Date:   Wed, 6 Jan 2021 03:57:59 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-alpha <linux-alpha@...r.kernel.org>
Subject: Re: [PATCH] fs: binfmt_em86: check return code of remove_arg_zero

On Tue, Dec 22, 2020 at 10:03 PM Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> remove_arg_zero is declared as __must_check. Looks like it can return
> -EFAULT on failure.
>
> Cc: Masahiro Yamada <masahiroy@...nel.org>
> Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Nick Desaulniers <ndesaulniers@...gle.com>

Cc'ing Alpha list too.

Alexander, fs-devel: pinging about this... We removed
ENABLE_MUST_CHECK in 196793946264 ("Compiler Attributes: remove
CONFIG_ENABLE_MUST_CHECK"), so this should be giving a warning now
unconditionally. In 5.12 it will likely become a build error.

Nick: thanks for the patch! (I missed it in December, sorry)

Reviewed-by: Miguel Ojeda <ojeda@...nel.org>

Cheers,
Miguel