lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jan 2021 21:42:21 +0100 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de> Cc: Nick Desaulniers <ndesaulniers@...gle.com>, Yoshinori Sato <ysato@...rs.sourceforge.jp>, Rich Felker <dalias@...c.org>, Paul Mundt <lethal@...ux-sh.org>, Guenter Roeck <linux@...ck-us.net>, linux-sh@...r.kernel.org, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] sh: check return code of request_irq On Fri, Jan 1, 2021 at 2:50 PM John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de> wrote: > > Verified on my SH-7785LCR board. Boots fine. > > Tested-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de> Thanks for testing, John! I think Masahiro was concerned about the error case (I assume you tested the happy path). In any case, if no maintainer suggests something else, looks good to me (and it is no worse than the status quo unless the `pr_err()` can somehow kill it), so: Reviewed-by: Miguel Ojeda <ojeda@...nel.org> Cheers, Miguel
Powered by blists - more mailing lists