lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 7 Jan 2021 15:52:56 -0500
From:   Steven Rostedt <>
To:     Linus Torvalds <>
Cc:     Willem de Bruijn <>,
        Jakub Kicinski <>,
        David Miller <>,
        Jonathan Lemon <>,
        Thomas Gleixner <>,
        LKML <>,
        "the arch/x86 maintainers" <>,
        Christoph Hellwig <>,
        Matthew Wilcox <>,
        Daniel Vetter <>,
        Andrew Morton <>,
        Linux-MM <>,
        Peter Zijlstra <>,
        Ingo Molnar <>,
        Juri Lelli <>,
        Vincent Guittot <>,
        Dietmar Eggemann <>,
        Ben Segall <>, Mel Gorman <>,
        Daniel Bristot de Oliveira <>,
        Netdev <>
Subject: Re: [BUG] from x86: Support kmap_local() forced debugging

On Thu, 7 Jan 2021 11:47:02 -0800
Linus Torvalds <> wrote:

> On Wed, Jan 6, 2021 at 8:45 PM Willem de Bruijn <> wrote:
> >
> > But there are three other kmap_atomic callers under net/ that do not
> > loop at all, so assume non-compound pages. In esp_output_head,
> > esp6_output_head and skb_seq_read. The first two directly use
> > skb_page_frag_refill, which can allocate compound (but not
> > __GFP_HIGHMEM) pages, and the third can be inserted with
> > netfilter xt_string in the path of tcp transmit skbs, which can also
> > have compound pages. I think that these could similarly access
> > data beyond the end of the kmap_atomic mapped page. I'll take
> > a closer look.  
> Thanks.
> Note that I have flushed my random one-liner patch from my system, and
> expect to get a proper fix through the normal networking pulls.
> And _if_ the networking people feel that my one-liner was the proper
> fix, you can use it and add my sign-off if you want to, but it really
> was more of a "this is the quick ugly fix for testing" rather than
> anything else.

Please add:

  Reported-by: Steven Rostedt (VMware) <>

And if you take Linus's patch, please add my:

  Tested-by: Steven Rostedt (VMware) <>

and if you come up with another patch, please send it to me for testing.


-- Steve

Powered by blists - more mailing lists