linux-kernel - Re: [PATCH] proc_sysclt: fix oops caused by incorrect command parameters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202101071307.6E0CF2FCA@keescook>
Date:   Thu, 7 Jan 2021 13:08:13 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Xiaoming Ni <nixiaoming@...wei.com>
Cc:     linux-kernel@...r.kernel.org, mcgrof@...nel.org,
        yzaikin@...gle.com, adobriyan@...il.com, vbabka@...e.cz,
        linux-fsdevel@...r.kernel.org, mhocko@...e.com,
        mhiramat@...nel.org, wangle6@...wei.com
Subject: Re: [PATCH] proc_sysclt: fix oops caused by incorrect command
 parameters.

On Thu, Jan 07, 2021 at 02:14:18PM +0800, Xiaoming Ni wrote:
> On 2021/1/7 7:46, Kees Cook wrote:
> > subject typo: "sysclt" -> "sysctl"
> > 
> > On Thu, Dec 24, 2020 at 03:42:56PM +0800, Xiaoming Ni wrote:
> > > [...]
> > > +	if (!val)
> > > +		return 0;
> > > +
> > >   	if (strncmp(param, "sysctl", sizeof("sysctl") - 1) == 0) {
> > >   		param += sizeof("sysctl") - 1;
> > 
> > Otherwise, yeah, this is a good test to add. I would make it more
> > verbose, though:
> > 
> > 	if (!val) {
> > 		pr_err("Missing param value! Expected '%s=...value...'\n", param);
> > 		return 0;
> > 	}
> > 
> Yes, it's better to add log output.
> Thank you for your review.
> Do I need to send V2 patch based on review comments?

Yes please. :)

-- 
Kees Cook