linux-kernel - Re: [PATCH v2 5/5] csky: Cleanup asm/spinlock.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/cCbByLzLI12xYZ@hirez.programming.kicks-ass.net>
Date:   Thu, 7 Jan 2021 13:45:32 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     guoren@...nel.org
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        linux-csky@...r.kernel.org, linux-arch@...r.kernel.org,
        Guo Ren <guoren@...ux.alibaba.com>,
        Will Deacon <will@...nel.org>
Subject: Re: [PATCH v2 5/5] csky: Cleanup asm/spinlock.h

On Sun, Dec 20, 2020 at 03:39:23PM +0000, guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> There are two implementation of spinlock in arch/csky:
>  - simple one (NR_CPU = 1,2)
>  - tick's one (NR_CPU = 3,4)
> Remove the simple one.
> 
> There is already smp_mb in spinlock, so remove the definition of
> smp_mb__after_spinlock.

Where ? Note that with qspinlock the fast path is
atomic_try_cmpxchg_acquire(), which does not imply anything of the sort.