linux-kernel - Re: [PATCH 2/2] drivers:tty:pty: Fix a race causing data loss on close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/co3Uq719eXempQ@kroah.com>
Date:   Thu, 7 Jan 2021 16:29:33 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Corey Minyard <cminyard@...sta.com>
Cc:     minyard@....org, Jiri Slaby <jirislaby@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Peter Hurley <peter@...leysoftware.com>,
        brian.bloniarz@...il.com
Subject: Re: [PATCH 2/2] drivers:tty:pty: Fix a race causing data loss on
 close

On Sat, Jan 02, 2021 at 08:41:09AM -0600, Corey Minyard wrote:
> On Mon, Nov 23, 2020 at 06:49:02PM -0600, minyard@....org wrote:
> > From: Corey Minyard <cminyard@...sta.com>
> > 
> > Remove the tty_vhangup() from the pty code and just release the
> > redirect.  The tty_vhangup() results in data loss and data out of order
> > issues.
> 
> It's been a while, so ping on this.  I'm pretty sure this is the right
> fix, the more I've thought about it.

Sorry, was waiting to see if someone else would review it :)

Will go do so now...

greg k-h