linux-kernel - Re: [PATCH v3 0/4] hwmon: (ltc2945): add support for sense resistor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Jan 2021 07:28:11 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        jdelvare@...e.com, mark.thoren@...log.com, ardeleanalex@...il.com
Subject: Re: [PATCH v3 0/4] hwmon: (ltc2945): add support for sense resistor

On Thu, Jan 07, 2021 at 12:34:13PM +0200, Alexandru Ardelean wrote:
> Changeset adds support for sense resistor.
> 
> Changelog v2 -> v3:
> * https://lore.kernel.org/linux-hwmon/20201111091259.46773-1-alexandru.ardelean@analog.com/
> * dropped patch 'docs: hwmon: (ltc2945): change type of val to ULL in ltc2945_val_to_reg()'
> * add patch 'hwmon: (ltc2945): clamp values before converting'
> * for patch 'hwmon: (ltc2945): add support for sense resistor'
>   - sense-resistor is represented in milli-ohms internally; this
>     risks of any other potential overflows with the multiplication to
>     1000; the scaling in the driver becomes simpler, but we can't allow
>     a lower resistor value that 1 mOhm, and all resistor values
>     need to be integer in mOhm.
>   - added max power and max amps limits, adjusted to sense resistor
> * for patch 'dt-bindings: hwmon: ltc2945: add device tree doc for ltc2945 '
>   added 'Reviewed-by: Rob Herring <robh@...nel.org>'
> 
> Alexandru Ardelean (4):
>   hwmon: (ltc2945): wrap regmap into an ltc2945_state struct
>   hwmon: (ltc2945): clamp values before converting
>   hwmon: (ltc2945): add support for sense resistor
>   dt-bindings: hwmon: ltc2945: add device tree doc for ltc2945
> 

As mentioned in patch 3/3, this series solves a generic problem
affecting all hwmon drivers, but it only solves it for one of those
drivers. We should work on a generic solution (in-kernel scaling)
instead, one that works for all hwmon drivers, not just one.

Thanks,
Guenter

>  .../bindings/hwmon/adi,ltc2945.yaml           |  49 +++++++
>  drivers/hwmon/ltc2945.c                       | 128 +++++++++++++++---
>  2 files changed, 156 insertions(+), 21 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
> 
> -- 
> 2.17.1
>