linux-kernel - Re: [PATCH v2 08/15] dt-bindings: avs: cpr: Convert binding to YAML schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Jan 2021 11:18:46 -0600
From:   Rob Herring <robh@...nel.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
Cc:     robh+dt@...nel.org, agross@...nel.org, bjorn.andersson@...aro.org,
        nks@...wful.org, daniel.lezcano@...aro.org, rjw@...ysocki.net,
        devicetree@...r.kernel.org, konrad.dybcio@...ainline.org,
        manivannan.sadhasivam@...aro.org, linux-pm@...r.kernel.org,
        martin.botka@...ainline.org, viresh.kumar@...aro.org,
        linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, marijn.suijten@...ainline.org
Subject: Re: [PATCH v2 08/15] dt-bindings: avs: cpr: Convert binding to YAML schema

On Sat, 09 Jan 2021 19:03:52 +0100, AngeloGioacchino Del Regno wrote:
> Convert the qcom,cpr.txt document to YAML schema and place it in the
> appropriate directory, since this driver was moved from power/avs
> to soc/qcom, but forgets to move the documentation.
> 
> Fixes: a7305e684fcf ("PM: AVS: qcom-cpr: Move the driver to the qcom specific drivers")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
> ---
>  .../bindings/power/avs/qcom,cpr.txt           | 131 +-----------------
>  .../bindings/soc/qcom/qcom,cpr.yaml           | 116 ++++++++++++++++
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 118 insertions(+), 131 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,cpr.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/soc/qcom/qcom,cpr.yaml:36:5: [warning] wrong indentation: expected 6 but found 4 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,cpr.example.dt.yaml: power-controller@...8000: nvmem-cells: [[4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295], [4294967295]] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,cpr.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,cpr.example.dt.yaml: power-controller@...8000: nvmem-cell-names: ['cpr_quotient_offset1', 'cpr_quotient_offset2', 'cpr_quotient_offset3', 'cpr_init_voltage1', 'cpr_init_voltage2', 'cpr_init_voltage3', 'cpr_quotient1', 'cpr_quotient2', 'cpr_quotient3', 'cpr_ring_osc1', 'cpr_ring_osc2', 'cpr_ring_osc3', 'cpr_fuse_revision'] is too long
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/qcom/qcom,cpr.yaml

See https://patchwork.ozlabs.org/patch/1424131

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.