linux-kernel - Re: [PATCH v2 19/34] xlink-core: Add xlink core device tree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1610299126.012552.785274.nullmailer@robh.at.kernel.org>
Date:   Sun, 10 Jan 2021 11:18:46 -0600
From:   Rob Herring <robh@...nel.org>
To:     mgross@...ux.intel.com
Cc:     paul.walmsley@...ive.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Seamus Kelly <seamus.kelly@...el.com>, markgross@...nel.org,
        damien.lemoal@....com, palmerdabbelt@...gle.com, corbet@....net,
        peng.fan@....com, arnd@...db.de, dragan.cvetic@...inx.com,
        leonard.crestez@....com, bp@...e.de, shawnguo@...nel.org,
        jassisinghbrar@...il.com, gregkh@...uxfoundation.org,
        robh+dt@...nel.org, Ryan Carnaghi <ryan.r.carnaghi@...el.com>
Subject: Re: [PATCH v2 19/34] xlink-core: Add xlink core device tree bindings

On Fri, 08 Jan 2021 13:25:45 -0800, mgross@...ux.intel.com wrote:
> From: Seamus Kelly <seamus.kelly@...el.com>
> 
> Add device tree bindings for keembay-xlink.
> 
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> Reviewed-by: Mark Gross <mgross@...ux.intel.com>
> Signed-off-by: Seamus Kelly <seamus.kelly@...el.com>
> Signed-off-by: Ryan Carnaghi <ryan.r.carnaghi@...el.com>
> ---
>  .../bindings/misc/intel,keembay-xlink.yaml    | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml:21:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml: 'additionalProperties' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml: ignoring, error in schema: 
warning: no schema found in file: ./Documentation/devicetree/bindings/misc/intel,keembay-xlink.yaml

See https://patchwork.ozlabs.org/patch/1423961

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.