linux-kernel - Re: [PATCH 0/2] perf/x86/intel/uncore: Derive die id from NUMA info with more than 8 nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa012ba7-714a-00bc-257c-62f7ddcde7fc@linux.intel.com>
Date:   Mon, 11 Jan 2021 11:39:21 -0500
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Steve Wahl <steve.wahl@....com>, rja_direct@...ups.int.hpe.com,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Cc:     "Liang, Kan" <kan.liang@...el.com>
Subject: Re: [PATCH 0/2] perf/x86/intel/uncore: Derive die id from NUMA info
 with more than 8 nodes



On 1/8/2021 10:35 AM, Steve Wahl wrote:
> For Intel uncore, the registers being used to identify the die don't
> contain enough bits to uniquely identify more than 8 dies.  On
> systems with more than 8 dies, this results in error messages of the
> form "skx_uncore: probe of XXXX:XX:XX.X failed with error -22", and
> some perf counters showing up as "<not supported>".
> 
> On such systems, use NUMA information to determine die id.
> 
> Continue to use the register information with 8 or fewer numa nodes to
> cover cases like NUMA not being enabled.
> 
> The first patch moves translation from physical to logical die id
> earlier in the code, and stores only the logical id.  The logical id
> is the only one that is really used.  Without this change the second
> patch would have to store both physical and logical id, which was much
> more complicated.
> 
> The second patch adds the alternative of deriving the logical die id
> from the NUMA information when there are more than 8 nodes.
> 
> Steve Wahl (2):
>    perf/x86/intel/uncore: Store the logical die id instead of the
>      physical die id.
>    perf/x86/intel/uncore: With > 8 nodes, get pci bus die id from NUMA
>      info
> 
>   arch/x86/events/intel/uncore.c       |  58 +++++---------
>   arch/x86/events/intel/uncore.h       |   5 +-
>   arch/x86/events/intel/uncore_snb.c   |   2 +-
>   arch/x86/events/intel/uncore_snbep.c | 114 ++++++++++++++++++---------
>   4 files changed, 99 insertions(+), 80 deletions(-)
> 

Thanks Steve for working on the issue. The patch set looks good to me.

Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks,
Kan