linux-kernel - Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec735a59-0fbd-3d4a-e997-895099a8e534@gmail.com>
Date:   Mon, 11 Jan 2021 08:41:19 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Mark Brown <broonie@...nel.org>,
        YANG LI <abaci-bugfix@...ux.alibaba.com>, kdasu.kdev@...il.com
Cc:     bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison



On 1/11/2021 8:29 AM, Mark Brown wrote:
> On Mon, 11 Jan 2021 17:26:29 +0800, YANG LI wrote:
>> Fix the following coccicheck warning:
>> ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> 
> Thanks!
> 
> [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison
>       commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8

I don't think that "style: " is a subject prefix that is used commonly
and it certainly should not belong in a commit subject. Mark can you
please people at least 10-12 hours to review changes before applying
them? This one is trivial except the commit subject does not match
previous changes done to this file and it should have been fixed.
-- 
Florian